Add a check on the issuer of the token for IRIS IAM#431
Draft
gregcorbett wants to merge 1 commit intoGOCDB:devfrom
Draft
Add a check on the issuer of the token for IRIS IAM#431gregcorbett wants to merge 1 commit intoGOCDB:devfrom
gregcorbett wants to merge 1 commit intoGOCDB:devfrom
Conversation
- Apache is not already doing this for us
Member
Author
This is only really an issue when we have multiple OIDC integrated IdP supported in the main codebase, so bumping to milestone 14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache is not already doing this for us
Either this needs to go in milestone 13, or a PR that refactors the IRIS IAM token to use the base class introduced by #430 (which also includes a check on the issuer.)