Merged
Conversation
- if an identifier is passed that doesn't correspond to an API credential, $authEnt is an empty array, not `null`. - updateLastUseTime does not fail if $authEnt does not exist. - this had the affect of authorising all identifiers, which meant having an identifier is suffcient ot access level 3 methods - it looks like this check was introduced after the restrictions on personal data were introduced, so the original change (b6c4101) may not have been as tested / reviewed to exhaustion as the initial restrictions were. - it's also possible the upgrade to Rocky8, PHP 7.4 and newer newer versions of ORM changed behaviour subtly. I can't find any documentation to support this, and to confirm behaviour of GOCDB prior to the above upgrades would involve spinning up an SL7/PHP5 GOCDB instance.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null.Testing done
Behaviour in 5.12.3, credentials vs access to endpoints
* erroneous behaviour, that is addressed by this fix.
Behaviour in 5.12.4, credentials vs access to endpoints