GPII-2404: Changed windows' display settings handler to retrieve all screen resolutions #121
Conversation
…creen resolutions - Modified the display settings handler to get both the current and all available screen resolutions in one JSON object. - Refactored the handler into a fluid component. - Updated the unit tests in light of the above.
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
…creen resolutions Reverted getScreenResolution() to return an object with just width and height, but modified getImpl() to add a "screen-resolution" property.
|
CI job passed. |
…resolutions Better way to set current screen resolution return value. Also, cleaned up some comments.
|
CI job passed. |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
@amatas, according to the console log, the VM creation timed out. No tests were run. Any idea why? |
|
ok to test |
|
CI job passed. |
|
@klown sorry but seems that the creation of the VM took so much time to install some things that the Jenkins aborted the task. Perhaps it was because the host was very busy with other tasks. Now the tests passed. |
|
@amatas no problem -- it's not your fault. Thanks for re-running it! |
…resolutions Removed unused functions.
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
@amatas Tapping your shoulder... |
|
ok to test |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
ok to test |
|
CI job passed. |
|
CI job passed. |
|
CI job passed. |
|
CI job passed. |
Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
|
CI job passed. |
|
CI job passed: https://ci.gpii.net/job/windows-tests/389/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/393/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/395/ |
Merge upstream master GPII windows branch into GPII-2404.
|
CI job failed: https://ci.gpii.net/job/windows-tests/415/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/417/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/444/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/452/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/469/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/470/ |
Merged in upstream master branch.
|
CI job passed: https://ci.gpii.net/job/windows-tests/493/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/512/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/519/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/522/ |
Stop acceptance tests crashing.
|
CI job passed: https://ci.gpii.net/job/windows-tests/527/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/532/ |
4 participants
@kaspermarkus, @javihernandez
The modifiications to the window settings handler analogous to the linux pull request.