GPII-4355: Updated build scripts and projects to use VS2017 build tools #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test". |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/1207/ |
|
While we're waiting to update CI to install VS2017 build tools, here is the log of a manual checkout/build from a local VM. [Build successful] |
…app release (i.e. not dev)
|
CI job failed: https://ci.gpii.net/job/windows-tests/1208/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/1209/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/1457/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, combined with the gpii-app/GPII-4355 PR, should fully enable Morphic for Windows to compile using modern (VS2017) developer tools and Node.js v10.16.3.
Please note that this branch is based on the current "master" branch of GPII/windows (which contains a bug which is preventing most of the "set" Settings Handlers from working). However it should be able to be merged with any recent production-quality commit in the master branch.
Critical: developers must upgrade their developer environment to Visual Studio 2017. The new build scripts use Microsoft's new "vswhere" utility (included with VS2017+) to locate MSBuild, CSC, environment variables, etc. This is a hard fork in the road...and we will need all the developers on our team (plus the CI environment) to move to VS2017 when this goes "live" in master.
For the future: The $visualStudioVersion PowerShell variable has been designed to support either a specific version (e.g. "15.0" for VS2017) or a range (e.g. "[15.0,16.0)" as an inclusive range for any VS2017'ish releases from v15.0 to v15.9999999999). This means that as we want to start adding support for VS2019 or other newer releases, we can simplly update the $visualStudioVersion variable to include a wider range of compiler versions. Our build may indeed be compatible with VS2019 as well, but I have not tested with VS2019 due to the fact that Electron still uses VS2017 in their documentation.