cryptol-saw-core: Only import nominal types from non-parameterized modules
#2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
added
the
subsystem: cryptol-saw-core
yav
approved these changes
Oct 7, 2025
sauclovian-g
approved these changes
Oct 7, 2025
RyanGlScott
force-pushed
the
T2673-cryptol-saw-core-import-nominal-types-fix
branch
from
01053c4 to
32556b1
Compare
RyanGlScott
deleted the
T2673-cryptol-saw-core-import-nominal-types-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't import nominal types from parameterized modules, as SAW doesn't know how to reason about these yet. (This was the cause of the panic seen in #2673.)
Fixes #2673.