traverseMirAggregate: Add a special case for empty MirAggregates
#2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
requested review from
spernsteiner,
qsctr,
samcowger and
sauclovian-g
RyanGlScott
added
the
subsystem: crucible-mir-comp
sauclovian-g
approved these changes
Oct 7, 2025
spernsteiner
approved these changes
Oct 7, 2025
Doing so is necessary to work around a bug in the implementation of `IntMap.mergeWithKey` that exists in pre-0.8 versions of the `containers` library (haskell/containers#979), which all currently supported versions of GHC currently use. See the newly added comments in `traverseMirAggregate` for the full story. Fixes #2687.
RyanGlScott
force-pushed
the
T2687-fix-traverseMirAggregate-bug
branch
from
1a1c5aa to
fe303c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so is necessary to work around a bug in the implementation of
IntMap.mergeWithKeythat exists in pre-0.8 versions of thecontainerslibrary (haskell/containers#979), which all currently supported versions of GHC currently use. See the newly added comments intraverseMirAggregatefor the full story.Fixes #2687.