1.21.5 SCUBA Gear rework #1137
Open
1.21.5 SCUBA Gear rework #1137
+1,229
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
added
feature-update
- updated helmet texture
Member
|
@EpyonProjects Test needs to be fixed |
BPR02
requested changes
Jul 9, 2025
Member
BPR02
left a comment
BPR02
left a comment
There was a problem hiding this comment.
Most stuff looks good. I left a comment about using scores instead of tags to track the buoyancy type since nbt checks are necessary to check tags in a predicate/enchantment, but it's probably not that big of a performance difference.
There's also an inapplicable test left which needs to be removed.
gm4_scuba_gear/data/gm4_scuba_gear/function/check_recipes.mcfunction
Outdated
Show resolved
Hide resolved
gm4_scuba_gear/data/gm4_scuba_gear/function/check_recipes.mcfunction
Outdated
Show resolved
Hide resolved
gm4_scuba_gear/data/gm4_scuba_gear/test/use_helmet_and_tank.mcfunction_
Outdated
Show resolved
Hide resolved
- I should be asleep - Addressed all of the concerns Beeps had - Should have checked again at literally any point because this really was not much
- Before putting it onto public server
BPR02
approved these changes
Nov 13, 2025
EpyonProjects
added
the
server-testing
BPR02
approved these changes
Nov 13, 2025
Member
|
EpyonProjects#6 is a PR that adds custom assets to the armor models (i.e. shown on the player model). It however, requires a resource pack to work. This is to be discussed during next meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main discussion and info source located on Discord in the forum post
tl;dr:
The wetsuit allows you to float in water, or assist with swimming up- or downwards. This enchant has a tick clock, making this rework the first introduction of GM4 enchants and the first case of an enchant clock. The enchantment is displayed using lore because it uses multiple lines and displays the attributes manually.