Blossoming Pots Optimizations, Compatibility & Tests #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
runcows
commented
Sep 14, 2025
runcows
commented
- Adds smithed.block checks
- Adds smithed.strict to all blossoming pots entities
- Changes second stage of mangrove propagule in decorated pot. The difference can only be seen with Vanilla Tweaks' visual sapling growth resource pack. All of the other saplings already support it, I had just missed this one previously
- Removes flower pot perma marker. Item data is now stored on the block display itself as custom data
- A lot of misc changes I made when looking through my old code
- Vanilla tweaks does have a second stage, I just missed it - Personally I don't think this warrants an upgrade path to upgrade old display entities, but i might change my mind later
- I have no idea why the tests aren't working. They worked on my machine :(
- fairly positive it was guidebook being given to dummys after a tick, considering the tests show a written book in the mainhand. - So now I will clear written book
…into blossoming-pots-revisited
TheThanathor
approved these changes
Nov 1, 2025
Member
TheThanathor
left a comment
TheThanathor
left a comment
There was a problem hiding this comment.
Tested in game and everything worked as expected.
Didn't check the update paths though, so if someone has some time to run through them that would be nice
Bloo-dev
approved these changes
Nov 6, 2025
Member
Bloo-dev
left a comment
Bloo-dev
left a comment
There was a problem hiding this comment.
FInally submitting this review I had lingering. I found nothing major, but can attest that the code looks good!
|
|
||
| # kill flower pot displays, perma marker, and temp marker | ||
| # kill flower pot displays, and temp marker | ||
| kill @e[type=minecraft:block_display,tag=gm4_blossoming_pots.display.flower_pot,distance=..0.1] |
Member
There was a problem hiding this comment.
Does this intentionally not have a limit=1?
Contributor
Author
There was a problem hiding this comment.
Yes, many of the flower pot displays use 2 display entities. With the storage being set up to be flexible, there is intentionally no limit so that a developer could in theory put as many displays as they want. In practice, I don't know if we'll ever use more than 3 though
gm4_blossoming_pots/data/gm4_blossoming_pots/function/flower/set_displays.mcfunction
Show resolved
Hide resolved
Bloo-dev
added
tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.