fix: ensure reentrancy guard is cleared on all exit paths in stake#586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stakesetREENTRANCY_GUARDbut did not clear it on every early-exit path (particularly insidehandle_cross_chain_stakewhich could panic after the guard was set). A stuck guard would permanently block future calls. Additionally,update_rewardhad no initialisation-check guard.Changes
contract/contracts/src/cross_chain.rs: refactorstaketo use aclearclosure that removes the guard before everypanic!/ early return. Move chain-validity checks intostakebefore delegating tohandle_cross_chain_stake, so panics in validation clear the guard first.contract/contracts/src/storage.rs: add an early-return guard inupdate_rewardwhen the contract is not yet initialised, preventing a spurious panic that would bypass the caller-side guard cleanup.Testing
stakereturns"reentrant call detected"without leaving the guard set.Closes #512