devex(contract): fix by formatting all contracts and adding formatting checks#588
Open
Hillzo wants to merge 1 commit into
Open
devex(contract): fix by formatting all contracts and adding formatting checks#588Hillzo wants to merge 1 commit into
Hillzo wants to merge 1 commit into
Conversation
Author
|
please kindly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #514
PR Description
This PR addresses formatting inconsistencies in the contracts workspace under issue #514. Previously, the contracts were formatted inconsistently (e.g., indents in function signatures and multiline comments), which caused the cargo formatting check in the CI pipeline to fail. However, because the CI check was allowed to continue on failure, it did not block PR builds.
To fix this:
contract/workspace have been formatted.These changes prevent unformatted code from reaching the remote repository and wasting CI resources.
Changes Made
contract/**/*.rsto fix [contract][devex] Run cargo fmt on all contracts #514..github/workflows/ci.ymlto removecontinue-on-error: truefrom the cargo formatting check step to address [contract][devex] Run cargo fmt on all contracts #514..githooks/pre-commitscript to check formatting before commits for [contract][devex] Run cargo fmt on all contracts #514.Testing
contractdirectory: