Skip to content

Support non integer division steps #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support non integer division steps #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85c8d86
Support non integer division steps
leragequit Sep 18, 2025
a4edc9c
added a null check for callbacks
leragequit Sep 19, 2025
cb0cdd7
fixed steps to actually mean steps, not step width ...
leragequit Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/linear_gauge/linear_gauge_painter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2178,7 +2178,7 @@ class RenderLinearGauge extends RenderBox
_movableWidget.onChanged!(value);
}
} else if (_pointerType is RenderLinearGaugeShapePointer) {
if (_movablePointer.isInteractive) {
if (_movablePointer.isInteractive && _movablePointer.onChanged != null) {
_movablePointer.onChanged!(value);
}
}
Expand Down
20 changes: 10 additions & 10 deletions lib/src/radial_gauge/radial_gauge_container_painter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@ class RenderRadialGaugeContainer extends RenderBox {
}

int calculateNumOfDivisions(int steps, double start, double end) {
double range = end - start.toDouble();
int numOfDivisions = range ~/ steps;

return numOfDivisions;
// double range = end - start.toDouble();
// int numOfDivisions = (range / steps).ceil();
// return numOfDivisions;
return steps;
}

@override
Expand All @@ -183,12 +183,12 @@ class RenderRadialGaugeContainer extends RenderBox {
getRadialGauge.track.trackStyle.primaryRulersHeight ?? 10;
double arcLength = endAngle - startAngle; // length of the arc in radians

double numParts = calculateNumOfDivisions(
getRadialGauge.track.steps,
getRadialGauge.track.start,
getRadialGauge.track.end,
).toDouble();

// double numParts = calculateNumOfDivisions(
// getRadialGauge.track.steps,
// getRadialGauge.track.start,
// getRadialGauge.track.end,
// ).toDouble();
double numParts = getRadialGauge.track.steps.toDouble();
// double radialOffset = getRadialGauge.valueBar!.first.radialOffset;

double partAngle = arcLength / numParts; // angle of each part in radians
Expand Down