Skip to content

131 make oc preds faster#140

Merged
audreyyeoCH merged 16 commits intomainfrom
131_make_ocPreds_faster
Sep 24, 2025
Merged

131 make oc preds faster#140
audreyyeoCH merged 16 commits intomainfrom
131_make_ocPreds_faster

Conversation

@audreyyeoCH
Copy link
Collaborator

Pull Request

@audreyyeoCH audreyyeoCH marked this pull request as draft July 22, 2025 13:13
@audreyyeoCH audreyyeoCH marked this pull request as ready for review September 22, 2025 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              91       3  96.70%   32, 62, 143
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2426     402  83.43%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  -------
R/dbetabinom.R      +10       0  +0.41%
TOTAL               +10       0  +0.07%

Results for commit: 110d7ef

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@danielinteractive
Copy link
Collaborator

Thanks @audreyyeoCH ,
please push another commit such that the tests run

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Unit Tests Summary

    1 files     20 suites   6m 14s ⏱️
  139 tests   138 ✅ 0 💤 1 ❌
1 322 runs  1 320 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 5d57ae6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprob 💚 $25.86$ $-1.00$ $0$ $0$ $0$ $0$
ocPredprob 💔 $3.21$ $+188.08$ $-1$ $0$ $0$ $0$
ocPredprobDist 💚 $95.42$ $-3.35$ $0$ $0$ $0$ $0$
ocRctPredprobDist 💚 $28.89$ $-1.08$ $0$ $0$ $0$ $0$
plotOc 💚 $214.11$ $-7.76$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprob 💔 $0.39$ $+188.31$ ocPredprob_correctly_shows_maximum_sample_size_when_no_decision_reached
ocPredprobDist 💚 $61.44$ $-2.27$ ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
plotOc 💚 $56.76$ $-1.97$ h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc 💚 $49.30$ $-1.98$ h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_TRUE
plotOc 💚 $105.07$ $-3.79$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status

Results for commit 2e7996c

♻️ This comment has been updated with latest results.

@audreyyeoCH audreyyeoCH merged commit b40a03b into main Sep 24, 2025
@audreyyeoCH audreyyeoCH deleted the 131_make_ocPreds_faster branch September 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments