Skip to content

137 hardcoded params#141

Merged
audreyyeoCH merged 35 commits intomainfrom
137_hardcoded_params
Jul 31, 2025
Merged

137 hardcoded params#141
audreyyeoCH merged 35 commits intomainfrom
137_hardcoded_params

Conversation

@audreyyeoCH
Copy link
Collaborator

@audreyyeoCH audreyyeoCH commented Jul 22, 2025

close #137 Thanks for your review @danielinteractive

edit : test that no interim results should appear if there is no early looks

@audreyyeoCH audreyyeoCH self-assigned this Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2416     402  83.36%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/betadiff.R               +19       0  +100.00%
R/ocRctPostprobDist.R       +8       0  +100.00%
R/plotBeta.R               +34      +4  -1.34%
R/plotDecision.R           +20       0  +100.00%
R/plotOc.R                  +5       0  +0.36%
TOTAL                      +86      +4  +0.44%

Results for commit: 98852f8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please see below, in particular please can you add tests for these bugs, such that they fail on current version and succeed on fixed version?

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files     20 suites   6m 6s ⏱️
  136 tests   136 ✅ 0 💤 0 ❌
1 311 runs  1 311 ✅ 0 💤 0 ❌

Results for commit 3fafb34.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprobDist 💔 $0.49$ $+1.80$ $+4$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPostprob 👶 $+0.19$ two_ocPostprob_calls_that_differ_in_parE_does_not_give_the_same_result.
ocPostprobDist 👶 $+1.80$ two_ocPostprobDist_calls_that_differ_in_parE_does_not_give_the_same_result.
ocRctPostprobDist 👶 $+0.30$ two_ocRctPostprobDist_calls_that_differ_in_parE_does_not_give_the_same_result.

Results for commit dc49eba

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please see below

audreyyeoCH and others added 6 commits July 30, 2025 17:46
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
@audreyyeoCH
Copy link
Collaborator Author

🥳

@audreyyeoCH audreyyeoCH merged commit ba8969b into main Jul 31, 2025
@audreyyeoCH audreyyeoCH deleted the 137_hardcoded_params branch July 31, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hard coded parameters in helper functions

3 participants

Comments