Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 98852f8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
danielinteractive
left a comment
There was a problem hiding this comment.
Thanks @audreyyeoCH , please see below, in particular please can you add tests for these bugs, such that they fail on current version and succeed on fixed version?
Contributor
Unit Tests Summary 1 files 20 suites 6m 6s ⏱️ Results for commit 3fafb34. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit dc49eba ♻️ This comment has been updated with latest results. |
audreyyeoCH
commented
Jul 23, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Collaborator
danielinteractive
left a comment
There was a problem hiding this comment.
Thanks @audreyyeoCH , please see below
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
danielinteractive
approved these changes
Jul 31, 2025
Collaborator
Author
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #137 Thanks for your review @danielinteractive
edit : test that no interim results should appear if there is no early looks