-
Notifications
You must be signed in to change notification settings - Fork 231
Add docformatter to format plain text in docstrings #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
17fe7a9
54213f7
b1e6f37
4d4e5bf
18602d6
f4ae7ba
09d1d5c
c102784
e6976d5
8988d66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,6 +6,8 @@ PYTEST_COV_ARGS=--cov=$(PROJECT) --cov-config=../pyproject.toml \ | |||||
--pyargs ${PYTEST_EXTRA} | ||||||
BLACK_FILES=$(PROJECT) setup.py doc/conf.py examples | ||||||
BLACKDOC_OPTIONS=--line-length 79 | ||||||
DOCFORMATTER_FILES=$(PROJECT) setup.py doc/conf.py examples | ||||||
DOCFORMATTER_OPTIONS=--recursive --pre-summary-newline --wrap-summaries 79 --wrap-descriptions 79 | ||||||
|
DOCFORMATTER_OPTIONS=--recursive --pre-summary-newline --wrap-summaries 79 --wrap-descriptions 79 | |
DOCFORMATTER_OPTIONS=--recursive --pre-summary-newline --make-summary-multi-line --wrap-summaries 79 --wrap-descriptions 79 |
Do we want to force --make-summary-multi-line
(see https://github.com/myint/docformatter/tree/v1.4#options)? This will turn every description (even short ones) into:
"""
This is a description.
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just find that PEP 257 says:
Unless the entire docstring fits on a line, place the closing quotes on a line by themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, seems like docformatter
didn't implement that one-line docstring PEP 257 guideline correctly? I think it's ok to just force multi-line though, as long as there's an automated solution.
Uh oh!
There was an error while loading. Please reload this page.