Fix ESLint flat config format in yennefer-observatory#3
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Co-authored-by: igor-holt <125706350+igor-holt@users.noreply.github.com>
Co-authored-by: igor-holt <125706350+igor-holt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on Observatory Architecture upgrade PR
Fix ESLint flat config format in yennefer-observatory
Jan 22, 2026
Open
There was a problem hiding this comment.
Pull request overview
Update yennefer-observatory to use ESLint v9+ flat config composition by removing legacy extends usage and composing plugin configs at the top level.
Changes:
- Removed
extendsfrom the per-files config object - Added
js,react-hooks, andreact-refreshrecommended configs directly to the top-level config array
Files not reviewed (1)
- yennefer-observatory/package-lock.json: Language not supported
Comment on lines
+9
to
13
| js.configs.recommended, | ||
| reactHooks.configs.flat.recommended, | ||
| reactRefresh.configs.vite, | ||
| { | ||
| files: ['**/*.{js,jsx}'], |
There was a problem hiding this comment.
This changes the scope of the recommended configs: previously they were applied only to **/*.{js,jsx} via the object that contained files, but now these configs apply globally (to every file ESLint considers). To keep the prior behavior, wrap/clone each recommended config entry with the same files glob (e.g., by spreading the config object and adding files) or move them into the same scoped config block so they only affect JS/JSX.
Suggested change
| js.configs.recommended, | |
| reactHooks.configs.flat.recommended, | |
| reactRefresh.configs.vite, | |
| { | |
| files: ['**/*.{js,jsx}'], | |
| { | |
| files: ['**/*.{js,jsx}'], | |
| ...js.configs.recommended, | |
| }, | |
| { | |
| files: ['**/*.{js,jsx}'], | |
| ...reactHooks.configs.flat.recommended, | |
| }, | |
| { | |
| files: ['**/*.{js,jsx}'], | |
| ...reactRefresh.configs.vite, | |
| }, | |
| { | |
| files: ['**/*.{js,jsx}'], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESLint configuration was using the legacy
extendsproperty, which is invalid in flat config format (ESLint v9+).Changes:
extendsproperty from configuration objectjs.configs.recommended,reactHooks.configs.flat.recommended,reactRefresh.configs.vite) directly in the top-level config arrayBefore:
After:
This enables proper config composition and plugin rule activation in ESLint's flat config system.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.