Improve permissions UI for users. #2198

anup39 · 2025-10-30T08:02:24Z

This pull request refactors the permission handling logic to ensure that the UI accurately reflects a user's ability to manage permissions for a resource. Specifically, it restricts the available permission options for the "Anyone" (anonymous) and "Registered users" (registered-members) groups if the current user does not have the appropriate management rights.

The Problem
Previously, the permissions dropdown in the "Share" panel would always show all possible permission levels (e.g., "None", "View", "Download"), even if the user lacked the can_manage_anonymous_permissions or can_manage_registered_member_permissions rights.

The Solution
The logic has been updated to dynamically filter the list of available permissions.

Conditional Filtering: If a user does not have management rights for a specific group, this function identifies the currently saved permission for that group and modifies the options list to contain only that single permission.
Created filterGroupPermissions Utility: A new, reusable helper function filterGroupPermissions has been added to ResourceUtils.js . This function is responsible for the core filtering logic.
Integration: The main getResourcePermissions function now uses this helper to process options for both the anonymous and registered-members groups before returning the final list to the UI component.

As a result, if a user cannot manage permissions for a group, the dropdown for that group will appear as a read-only field displaying the current permission, preventing any attempts to change it.

This array represents the currently saved permissions for the resource.(from compactPermissions.groups)

[
    { "name": "anonymous", "permissions": "download" },
    { "name": "registered-members", "permissions": "view" }
]

(Initial permission options from the API)
This object contains all possible permission levels for each group type before filtering.

{
    "anonymous": [
        { "name": "none", "label": "None" },
        { "name": "view", "label": "View" },
        { "name": "download", "label": "Download" }
    ],
    "registered-members": [
        { "name": "none", "label": "None" },
        { "name": "view", "label": "View" },
        { "name": "download", "label": "Download" }
    ]
}

Flow Diagram
The following diagram illustrates the new logic implemented:

…nto feat_disable_certain_perms

gemini-code-assist · 2025-10-30T08:02:39Z

Summary of Changes

Hello @anup39, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface for permission management by implementing a more robust and secure system. It ensures that users are only presented with permission options they are authorized to modify, specifically for anonymous and registered user groups. By dynamically filtering available choices and making unauthorized fields read-only, the change improves both the clarity and integrity of the permission settings within the application.

Highlights

Refactored Permission UI Logic: The pull request refactors the permission handling logic to ensure the UI accurately reflects a user's ability to manage permissions for a resource, specifically for 'Anyone' and 'Registered users' groups.
Dynamic Permission Filtering: The permissions dropdown in the 'Share' panel now dynamically filters available permission options, restricting them if the current user lacks the can_manage_anonymous_permissions or can_manage_registered_member_permissions rights.
New Utility Function: A new reusable helper function, filterGroupPermissions, has been added to ResourceUtils.js to encapsulate the core filtering logic for group permissions.
Read-Only Permission Display: If a user cannot manage permissions for a specific group, the corresponding dropdown will appear as a read-only field, displaying only the current permission and preventing unauthorized changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a valuable UI improvement by filtering the available permission options based on the user's management rights. The logic is encapsulated in new helper functions within ResourceUtils.js, which is a good approach. My review focuses on improving the robustness and maintainability of these new functions and ensuring they are adequately tested. I've suggested adding more specific JSDoc types, avoiding argument mutation to prevent side effects, and adding a default parameter value. Most importantly, I've highlighted the need for comprehensive unit tests to cover the new permission filtering logic, which is currently missing.

gemini-code-assist · 2025-10-30T08:04:13Z

geonode_mapstore_client/client/js/utils/__tests__/ResourceUtils-test.js

+        const groups = [];
+        const permissionOptions = getResourcePermissions(data[0].allowed_perms.compact, groups);


The test for getResourcePermissions has been updated for the new function signature, but the new permission filtering logic is not covered by any tests. It is crucial to add tests for this new functionality to ensure it works correctly and to prevent future regressions.

Please add test cases that cover:

A user who can manage permissions (options should not be filtered).

A user who cannot manage permissions (options should be filtered to only the current permission).

Scenarios for both anonymous and registered-members groups.

Edge cases, such as when a group's current permission is not set.

gemini-code-assist · 2025-10-30T08:04:13Z

geonode_mapstore_client/client/js/utils/ResourceUtils.js

+ * @param {*} groupName
+ * @param {*} groups


For better code clarity and maintainability, it's recommended to use specific types in JSDoc instead of the generic *. For instance, groupName is a string and groups is an array of group objects.

Suggested change

* @param {*} groupName

* @param {*} groups

* @param {string} groupName

* @param {object[]} groups

gemini-code-assist · 2025-10-30T08:04:13Z

geonode_mapstore_client/client/js/utils/ResourceUtils.js

 */
-export const getResourcePermissions = (options) => {
-    const permissionsOptions = {};
+export const getResourcePermissions = (options , groups, manageAnonymousPermissions=false, manageRegisteredMemberPermissions=false) => {


The getResourcePermissions function has default values for manageAnonymousPermissions and manageRegisteredMemberPermissions, but not for groups. To improve robustness and make the function signature clearer, consider adding a default value for groups, such as an empty array.

Suggested change

export const getResourcePermissions = (options , groups, manageAnonymousPermissions=false, manageRegisteredMemberPermissions=false) => {

export const getResourcePermissions = (options , groups = [], manageAnonymousPermissions=false, manageRegisteredMemberPermissions=false) => {

gemini-code-assist · 2025-10-30T08:04:13Z

geonode_mapstore_client/client/js/utils/ResourceUtils.js

+    filterGroupPermissions(options, groups, 'anonymous', manageAnonymousPermissions);
+    filterGroupPermissions(options, groups, 'registered-members', manageRegisteredMemberPermissions);
+    let permissionsOptions = {};
    Object.keys(options).forEach((key) => {


The filterGroupPermissions function mutates the options object. It's a good practice to avoid mutating function arguments to prevent potential side effects. Consider creating a copy of the options object before filtering to ensure the original object remains unchanged.

Suggested change

filterGroupPermissions(options, groups, 'anonymous', manageAnonymousPermissions);

filterGroupPermissions(options, groups, 'registered-members', manageRegisteredMemberPermissions);

let permissionsOptions = {};

Object.keys(options).forEach((key) => {

const optionsCopy = JSON.parse(JSON.stringify(options));

filterGroupPermissions(optionsCopy, groups, 'anonymous', manageAnonymousPermissions);

filterGroupPermissions(optionsCopy, groups, 'registered-members', manageRegisteredMemberPermissions);

let permissionsOptions = {};

Object.keys(optionsCopy).forEach((key) => {

giohappy · 2025-11-10T12:10:21Z

@anup39 this is blocked with no reviewers assigned.
Conflicts must be fixed.

allyoucanmap · 2025-11-10T13:06:29Z

geonode_mapstore_client/client/js/plugins/Share/Share.jsx

+ */
+
+import React from 'react';
+import PropTypes from 'prop-types';


Note previous PR moved code about share to another component #2204

We should not include the plugin again if it was removed previously. Now share is a tab in resources details component see DetailsShare.jsx. Please review the code

allyoucanmap · 2025-11-10T13:20:14Z

geonode_mapstore_client/client/js/utils/ResourceUtils.js

+const filterGroupPermissions = (options, groups, groupName, canManage) => {
+    if (!canManage && options[groupName]) {
+        const permissionValue = getPermissionForGroup(groupName, groups);
+        const currentPermission = options[groupName].find(p => p.name === permissionValue);
+        if (currentPermission) {
+            options[groupName] = [currentPermission];
+        }
+    }
+};


let's avoid to mutate the argument object and return a new object instead, see the example below (please double check the code):

We could also try to check all groups in same function

const filterGroupPermissions = (options, groups, groupNames) => { return groupNames.length ? Object.fromEntries(Object.keys(options) .map((key) => { if (groupNames.some(name => name === key)) { const permissionValue = getPermissionForGroup(key, groups); const currentPermission = options[key].find(p => p.name === permissionValue); return currentPermission ? [key, currentPermission] : [key, options[key]] } return [key, options[key]] })) : options; };

allyoucanmap · 2025-11-10T13:22:44Z

geonode_mapstore_client/client/js/utils/ResourceUtils.js

+    filterGroupPermissions(options, groups, 'anonymous', manageAnonymousPermissions);
+    filterGroupPermissions(options, groups, 'registered-members', manageRegisteredMemberPermissions);


based on previous comment, please double check this

const options = filterGroupPermissions(_options, groups, [ ...(manageAnonymousPermissions ? [] : ['anonymous']), ...(manageRegisteredMemberPermissions? [] : ['registered-members']), ])

Anup Dahal added 3 commits October 30, 2025 13:12

Feat : addtional permissions check to manage a resource permissions

1734725

Merge branch 'master' of github.com:GeoNode/geonode-mapstore-client i…

d73ff6b

…nto feat_disable_certain_perms

Removed unsed import

04ccaac

anup39 self-assigned this Oct 30, 2025

anup39 added the geonode-ui label Oct 30, 2025

gemini-code-assist bot reviewed Oct 30, 2025

View reviewed changes

allyoucanmap assigned allyoucanmap and unassigned allyoucanmap Nov 10, 2025

allyoucanmap self-requested a review November 10, 2025 12:13

allyoucanmap assigned allyoucanmap and unassigned anup39 Nov 10, 2025

Fixed merged conflict

0fbf21f

allyoucanmap requested changes Nov 10, 2025

View reviewed changes

Anup Dahal added 4 commits November 11, 2025 13:23

Fixed conflict

b8936f2

Updated logic of DetailsShare for Permissions

0ef7d87

Removed share component

e592b4e

Fixed linting issues

c71665a

anup39 requested a review from allyoucanmap November 11, 2025 08:34

Fixed typo

8e263ca

allyoucanmap approved these changes Nov 11, 2025

View reviewed changes

allyoucanmap merged commit 0db4795 into GeoNode:master Nov 11, 2025
1 check passed

		const groups = [];
		const permissionOptions = getResourcePermissions(data[0].allowed_perms.compact, groups);

	export const getResourcePermissions = (options , groups, manageAnonymousPermissions=false, manageRegisteredMemberPermissions=false) => {
	export const getResourcePermissions = (options , groups = [], manageAnonymousPermissions=false, manageRegisteredMemberPermissions=false) => {

		filterGroupPermissions(options, groups, 'anonymous', manageAnonymousPermissions);
		filterGroupPermissions(options, groups, 'registered-members', manageRegisteredMemberPermissions);

Improve permissions UI for users. #2198

Improve permissions UI for users. #2198

Uh oh!

Conversation

anup39 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 30, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

giohappy commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allyoucanmap Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

anup39 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

allyoucanmap Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

anup39 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

allyoucanmap Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

anup39 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anup39 commented Oct 30, 2025 •

edited

Loading

giohappy commented Nov 10, 2025 •

edited

Loading