-
Notifications
You must be signed in to change notification settings - Fork 77
feat: support multiple channel lists with ChannelPaginatorsOrchestrator #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Size Change: +33.7 kB (+9.49%) 🔍 Total Size: 388 kB
|
src/ChannelPaginatorsOrchestrator.ts
Outdated
| }; | ||
|
|
||
| // fixme: is it ok, remove item just because its property hidden is switched to hidden: true? What about offset cursor, should we update it? | ||
| const channelHiddenHandler: LabeledEventHandler<ChannelPaginatorsOrchestratorEventHandlerContext> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct - channel should not be removed from all the lists. There may be lists that have filter {hidden: true} - meaning, show me hidden channels. I will remove this from the orchestrator and move it to the legacy React ChannelList implementation.
cc9f72b to
83bd4ef
Compare
Support setting paginator items directly, optional request retries, offline DB in ChannelPaginator, identification of pagination restart based on query shape change.
83bd4ef to
f63c7ca
Compare
…has_unread, last_updated
…n other matching paginators
Goal
Allow integrators to keep multiple parallel channel listings that keep their own pagination state but probably differ in filters.
The feature brings support of:
member.user.name,pinned,members) - custom filter-to-value resolversExample use
A list of lists (
ChannelLists):Specific
ChannelList:Things to consider / improvements: