Skip to content

fix: Fix some of the French i18n translations #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tmoran-stenoa
Copy link

🎯 Goal

Fix a few inaccurate or missing French translations.

🛠 Implementation details

I am a native French speaker from Canada. I was reviewing the French translations and found that a few of them were inaccurate, missing, or had some grammatical or semantic errors, so I volunteered to make a few fixes.

Note: I have not tested the changes. Feel free to accept/reject/modify any of the changes I made.

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

Change your app to French and check that the translations render properly and that they make sense.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic
Copy link
Contributor

Hi @tmoran-stenoa ,

Thanks for your contribution ! I'll have a look at this soon.

"Unban User": "Débannir Utilisateur",
"Unblock User": "Débloquer Utilisateur",
"Type a number from 2 to 10": "Saisissez un nombre de 2 à 10",
"Unban User": "Débannir l'utilisateur",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Débannir" does not exist. I would say "Accepter l'utilisateur". You can look here for other ideas of synonimous https://www.larousse.fr/dictionnaires/synonymes/bannir/2308

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the word was there before, I simply changed "Débannir Utilisateur" to "Débannir l'utilisateur". I personally think "débannir" has the clearest meaning compared to the alternatives like "Accepter" and others in the Larousse. This could be important given that there is also "Débloquer", which could lead to confusions. However if you feel strongly about "Accepter", feel free to go ahead and make the edit (you should have permissions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants