Fix/1414/pinned message padding #3172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the latest changes
|
Hey @pardhan03, the PR doesn't seem to fix the crux of the issue which was already fixed during the design refinements in V6. So, I will close the PR. Your fix seems to raise the entire content by 4px wrt to the MessageAvatar which doesn't look good on the UI. Fixed design on V6: After your fix: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414
What this PR does
This PR fixes the UI bug where pinned messages didn’t have bottom padding when they were not the last in a message group.
🛠
added the paddingVertical in MessageSimple.txs component where the message is rendered.
Before
After