Skip to content

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jul 18, 2025

The goal of the PR is to add static and live locations support for the RN SDK.

  • This architecturally uses the Live locations manager from the client to maintain the active locations state for a message.
  • The integrators can add their own map integration to the MessageLocation component which is kept blank by default and are for integrators to pass on their maps.
  • The examples of integration is added to both expo and sample app.
  • The PR introduces a LiveLocationManagerContext that the integrator has to wrap in the component tree to use the feature which would expose the LLC's LiveLocationManager to the hierarchy. For this they need to pass their watchLocation implementation and getDeviceId which can be a temporary function.
  • For the map screens the integrators can use the useHandleLiveLocationEvents that would return the state depending on the event so that the components can use it.
  • The offline support for the shared_location of the message and active_live_locations state of the channel is handled as well.
Screen.Recording.2025-07-21.at.4.51.52.PM.mov

@khushal87 khushal87 marked this pull request as ready for review July 21, 2025 11:27
@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Jul 23, 2025

SDK Size

title develop branch diff status
js_bundle_size 283 KB 284 KB +914 B 🔴

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any LLC changes with regards to offline support, are live locations updated only through things like channel.updated or something ? Are there no live location WS events ?

@isekovanic
Copy link
Contributor

I cannot see any LLC changes with regards to offline support, are live locations updated only through things like channel.updated or something ? Are there no live location WS events ?

Also, when do we remove live locations from the offline DB ? I can't see them being deleted anywhere

@khushal87
Copy link
Member Author

I cannot see any LLC changes with regards to offline support, are live locations updated only through things like channel.updated or something ? Are there no live location WS events ?

Also, when do we remove live locations from the offline DB ? I can't see them being deleted anywhere

Well we don't because one the live location is ended it turns to a static location and should still persist in the UI. The only time where it makes sense to be deleted it when the message with location is actually deleted. If you want I can add it won't be a big deal in the deleteMessage DB API.

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any changes in the LLC with regards to offline support,

@khushal87 khushal87 merged commit 22b009f into develop Jul 29, 2025
4 of 7 checks passed
@khushal87 khushal87 deleted the feat/live-location branch July 29, 2025 05:49
@github-actions github-actions bot mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants