-
Notifications
You must be signed in to change notification settings - Fork 349
feat: add static and live locations support #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see any LLC changes with regards to offline support, are live locations updated only through things like channel.updated
or something ? Are there no live location WS events ?
package/src/contexts/liveLocationManagerContext/LiveLocationManagerContext.tsx
Show resolved
Hide resolved
Also, when do we remove live locations from the offline DB ? I can't see them being deleted anywhere |
Well we don't because one the live location is ended it turns to a static location and should still persist in the UI. The only time where it makes sense to be deleted it when the message with location is actually deleted. If you want I can add it won't be a big deal in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see any changes in the LLC with regards to offline support,
The goal of the PR is to add static and live locations support for the RN SDK.
MessageLocation
component which is kept blank by default and are for integrators to pass on their maps.LiveLocationManagerContext
that the integrator has to wrap in the component tree to use the feature which would expose the LLC's LiveLocationManager to the hierarchy. For this they need to pass theirwatchLocation
implementation andgetDeviceId
which can be a temporary function.useHandleLiveLocationEvents
that would return the state depending on the event so that the components can use it.Screen.Recording.2025-07-21.at.4.51.52.PM.mov