Skip to content

Fix company dashboard greeting fallback#115

Open
eutv2022 wants to merge 1 commit into
Ghbounty:mainfrom
eutv2022:fix-company-greeting-fallback
Open

Fix company dashboard greeting fallback#115
eutv2022 wants to merge 1 commit into
Ghbounty:mainfrom
eutv2022:fix-company-greeting-fallback

Conversation

@eutv2022
Copy link
Copy Markdown

Closes #70.

This prevents the company dashboard from rendering a missing company name as undefined.

Change:

  • Use a trimmed company name when present
  • Fall back to there so the heading renders Welcome back, there for fresh signups without a company name
  • Preserve the existing greeting when company.name is set

Verified:

  • corepack pnpm --filter frontend exec eslint app/app/company/page.tsx
  • corepack pnpm --filter frontend test (217 tests passed)

Note: corepack pnpm --filter frontend lint currently fails on pre-existing lint errors in unrelated files; the modified file passes ESLint directly.

@eutv2022 eutv2022 requested a review from tomazzi14 as a code owner May 28, 2026 22:32
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

Someone is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel.

A member of the Team first needs to authorize it.

@eutv2022
Copy link
Copy Markdown
Author

Note on the Vercel bot comment: that appears to be only the preview deployment authorization for the GHBounty Vercel team. It is not related to this code change.

Local verification for this PR:

  • corepack pnpm --filter frontend exec eslint app/app/company/page.tsx ?
  • corepack pnpm --filter frontend test ? 217 tests passed

corepack pnpm --filter frontend lint still reports pre-existing unrelated lint errors across the repo, but the modified file is lint-clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: dashboard greeting shows 'Hello, undefined' for users without a name

1 participant