Open
Conversation
rito528
force-pushed
the
docs/add-serarch-engine-design-doc
branch
from
510630e to
6bd725a
Compare
kory33
reviewed
Apr 3, 2025
Member
kory33
left a comment
kory33
left a comment
There was a problem hiding this comment.
ここ二週間くらい色々立て込んでて本当に遅くなりました、マジで申し訳ないです…
基本的なドキュメントの流れとしては良いと思います！
全体に目を通して、特にドキュメントの方向性に与える前半部分についてコメントしました。前半部分が洗練されたら（i.e. ドキュメントの方向性としてよさそうというのが見えたら）、後半をその前半部分と照らし合わせてレビューする、という流れでやっていくでどうでしょうか（あと一往復するイメージ）？
Co-authored-by: Kory | Ryosuke Kondo <6561358+kory33@users.noreply.github.com>
Member
Author
|
@kory33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
文脈: https://discord.com/channels/237758724121427969/959299646725951580/1350294505101852784