feat: Add sunrise/sunset trigger doc#335
feat: Add sunrise/sunset trigger doc#335cicoub13 wants to merge 1 commit intoGladysAssistant:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTwo new documentation pages were added (English and French) describing Sun-triggered scenes for exact sunrise/sunset and delayed triggers (before/after), with front matter, examples, and illustrative images. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@i18n/fr/docusaurus-plugin-content-docs/current/scenes/sunset-sunrise.md`:
- Around line 14-20: Corriger la formulation des exemples de déclenchement :
remplacer « A chaque lever du soleil » et « A chaque coucher du soleil » par « À
chaque lever du soleil » et « À chaque coucher du soleil » (ajout des accents)
et accorder le verbe au pluriel en remplaçant « déclenchera la scène » par «
déclencheront la scène » pour que la tournure s’accorde avec les deux exemples ;
appliquez la même correction si la variante sans délai utilise la même phrase.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
static/img/docs/en/scenes/sunset-sunrise/sunrise_sunset_exact.pngis excluded by!**/*.pngstatic/img/docs/en/scenes/sunset-sunrise/sunset_sunrise_before_after.pngis excluded by!**/*.pngstatic/img/docs/fr/scenes/sunset-sunrise/sunrise_sunset_exact.pngis excluded by!**/*.pngstatic/img/docs/fr/scenes/sunset-sunrise/sunset_sunrise_before_after.pngis excluded by!**/*.png
📒 Files selected for processing (2)
docs/scenes/sunset-sunrise.mdi18n/fr/docusaurus-plugin-content-docs/current/scenes/sunset-sunrise.md
i18n/fr/docusaurus-plugin-content-docs/current/scenes/sunset-sunrise.md
Outdated
Show resolved
Hide resolved
cae2fac to
0450abc
Compare
Summary by CodeRabbit