Refactors glasses connection handling. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves glasses connection and disconnection logic to handle unavailable glasses more robustly. Renames `on_start_display` and `on_stop_display` to `on_allocate_render_textures` and `on_deallocate_render_textures` respectively to better reflect their purpose. Adds a monitor task for unavailable glasses and logic to re-attempt connection. Adds the `set_existing` API to the Glasses class to separate glasses handle creation from the state of being existing member of the NDK glasses list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves glasses connection and disconnection logic to handle unavailable glasses more robustly.
Renames
on_start_displayandon_stop_displaytoon_allocate_render_texturesandon_deallocate_render_texturesrespectively to better reflect their purpose.Adds a monitor task for unavailable glasses and logic to re-attempt connection.
Adds the
set_existingAPI to the Glasses class to separate glasses handle creation from the state of being existing member of the NDK glasses list.