Skip to content

core: render Render Blocking insight as a warning - #17146

Open
Manohar2503 wants to merge 1 commit into
GoogleChrome:mainfrom
Manohar2503:render-blocking-warning
Open

core: render Render Blocking insight as a warning#17146
Manohar2503 wants to merge 1 commit into
GoogleChrome:mainfrom
Manohar2503:render-blocking-warning

Conversation

@Manohar2503

Copy link
Copy Markdown

Summary

Changes the Render Blocking insight to be displayed as a warning (amber) instead of an error (red).

What changed

  • Override the failed Render Blocking insight to use scoreDisplayMode: numeric
  • Set the score to 0.5 for failed insights so it renders as an amber warning
  • Regenerated core/test/results/sample_v2.json

Testing

  • Ran renderer tests
  • Regenerated sample_v2.json
  • Ran yarn type-check
  • Ran yarn lint

@Manohar2503
Manohar2503 requested a review from a team as a code owner July 25, 2026 18:58
@Manohar2503
Manohar2503 requested review from paulirish and removed request for a team July 25, 2026 18:58
@google-cla

google-cla Bot commented Jul 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Manohar2503 Manohar2503 changed the title Change Render Blocking insight from error to warning change Render Blocking insight from error to warning Jul 25, 2026
@Manohar2503 Manohar2503 changed the title change Render Blocking insight from error to warning fix: change Render Blocking insight from error to warning Jul 25, 2026
@Manohar2503 Manohar2503 changed the title fix: change Render Blocking insight from error to warning core: render Render Blocking insight as a warning Jul 25, 2026
@Manohar2503

Copy link
Copy Markdown
Author

Hi @paulirish, just following up on this PR. Whenever you have a chance, I'd really appreciate a review. If there are any changes or improvements you'd like me to make, I'm happy to update the PR. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant