new_audit(best-practices): add React development mode audit - #17157
Open
plutoTaco wants to merge 2 commits into
Open
new_audit(best-practices): add React development mode audit#17157plutoTaco wants to merge 2 commits into
plutoTaco wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This introduces a
new_auditto the Best Practices category.React development builds are unoptimized and significantly larger than production builds, which negatively impacts page load performance. This PR introduces a new Gatherer and Audit to detect if a target page is currently running an unoptimized React development build.
react-dev-mode.js): UtilizesPage.addScriptToEvaluateOnNewDocumentduring thestartInstrumentationlifecycle to safely inject a dummy__REACT_DEVTOOLS_GLOBAL_HOOK__. This intercepts the React renderer upon boot to evaluatebundleTypebefore the page fully loads, bypassingNO_FCPtimeouts.react-dev-mode.js): Scores a0if a development build is detected, and1if running in production (or if React is not present).Related Issues/PRs
core/config/default-config.jsas required.core/test/audits/react-dev-mode-test.js.descriptionto explain both importance and remediation, as an official reference doc does not exist yet.