Skip to content

replace nonstandard string.trimright() with regex - #10

Open
nchen63 wants to merge 2 commits into
GoogleChromeLabs:masterfrom
nchen63:patch-1
Open

replace nonstandard string.trimright() with regex#10
nchen63 wants to merge 2 commits into
GoogleChromeLabs:masterfrom
nchen63:patch-1

Conversation

@nchen63

@nchen63 nchen63 commented Feb 7, 2019

Copy link
Copy Markdown

trimright/trimend is in stage 3 proposal https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimEnd, so replacing with regex

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@nchen63

nchen63 commented Feb 7, 2019

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@nchen63 nchen63 changed the title replace string.trimright() which is a js proposal replace nonstandard string.trimright() with regex Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants