Skip to content

Adding Additional Data-Attribute Configurations - #18

Open
pmaher wants to merge 6 commits into
GoogleChromeLabs:masterfrom
guitarcenterdev:master
Open

Adding Additional Data-Attribute Configurations#18
pmaher wants to merge 6 commits into
GoogleChromeLabs:masterfrom
guitarcenterdev:master

Conversation

@pmaher

@pmaher pmaher commented Oct 6, 2019

Copy link
Copy Markdown

Adding data attribute configurations for:

  1. The maximum amount and element can be scaled (very similar to the min-scale attr)
  2. Preventing the movement of a pinch zoom element until it's first zoomed in.

Patrick Maher and others added 6 commits September 5, 2019 14:57
Limit the amount a pinch-zoom element can be zoomed in via a data attribute
Adding configuration to prevent movement of the pinch-zoom element until the object has been scaled
Changing name back to the original since this will not be a regisered repo
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pmaher

pmaher commented Oct 6, 2019 via email

Copy link
Copy Markdown
Author

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants