Skip to content

Add Two-Finger Panning and some other attributes - #26

Open
edman007 wants to merge 9 commits into
GoogleChromeLabs:masterfrom
edman007:master
Open

Add Two-Finger Panning and some other attributes#26
edman007 wants to merge 9 commits into
GoogleChromeLabs:masterfrom
edman007:master

Conversation

@edman007

Copy link
Copy Markdown

Hi,

I made some modifications to this, the major changes are:

  • New Attribute "max-scale", allows you to limit the scaling
  • Bumped the version of the dependency pointerTracker (we really do need canceled events)
  • New attribute "no-default-pan", set to true or 1 to enable. When enabled one finger panning does not work initially allowing you to scroll on mobile with one finger
  • New attribute "two-finger-pan", disables one finger panning entirely, only two finger panning works, again, allows scrolling on mobile

These new attributes don't affect panning with a mouse. And I think these panning modifications are important on mobile so you don't accidently get stuck on a and can't scroll past it...

@google-cla

google-cla Bot commented Dec 29, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@edman007

Copy link
Copy Markdown
Author

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant