Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/scripts/configure-runners.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ REPO_OWNER="GoogleCloudPlatform"
GH_RUNNER_VERSION="2.299.1"

MACHINE_TYPE="n1-highmem-32"
BOOT_DISK_SIZE="200GB"
BOOT_DISK_SIZE="500GB"

VERBOSE=0

Expand Down Expand Up @@ -171,7 +171,7 @@ gcloud secrets add-iam-policy-binding $SECRET_NAME \
--role roles/secretmanager.secretAccessor

# Create instance template
IMAGE_FAMILY="ubuntu-2004-lts"
IMAGE_FAMILY="ubuntu-2204-lts"
IMAGE_PROJECT="ubuntu-os-cloud"
BOOT_DISK_TYPE="pd-balanced"
SCOPE="cloud-platform"
Expand Down Expand Up @@ -200,7 +200,7 @@ ZONE="us-central1-a"
if [ $VERBOSE -eq 1 ]; then echo; echo "Creating instance group: $INSTANCE_GROUP_NAME with $SIZE runners in $ZONE..."; fi
gcloud compute instance-groups managed create $INSTANCE_GROUP_NAME \
--size=${SIZE} \
--base-instance-name=nokill-${BASE_NAME} \
--base-instance-name=nokill-${RUNNER_NAME} \
--template=$INSTANCE_TEMPLATE_NAME \
--zone=$ZONE

Expand Down
9 changes: 8 additions & 1 deletion .github/scripts/startup-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu \
$(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
sudo apt update
sudo apt install docker-ce docker-ce-cli containerd.io docker-compose-plugin -y
# Pin Docker version to 20.10.x which supports API version 1.32.
# This is required because some integration tests transitively depend on older versions of
# testcontainers (e.g., 1.19.7) which rely on this older Docker API version.
# Newer Docker versions (e.g., 23.x, 24.x) have dropped support for API 1.32, causing
# "BadRequestException: client version 1.32 is too old" errors during test execution.
# We can unpin the docker version and install latest docker when testcontainer version is upgraded in Apache Beam.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking this PR, can you provide which test container needs to be upgraded and if possible open PRs in Apache Beam repo, thanks!

DOCKER_VERSION_STRING="5:20.10.24~3-0~ubuntu-$(lsb_release -cs)"
sudo apt install docker-ce=$DOCKER_VERSION_STRING docker-ce-cli=$DOCKER_VERSION_STRING containerd.io docker-compose-plugin -y

# add user to docker group
sudo groupadd docker
Expand Down
Loading