Skip to content

Refactor Azure relational DB instance readiness check and add Azure SQL MI skeleton. #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bvliu wants to merge 1 commit into from
Closed

Refactor Azure relational DB instance readiness check and add Azure SQL MI skeleton. #6340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions perfkitbenchmarker/providers/azure/azure_flexible_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import json
import logging
import re
import time
from typing import Any, Tuple

from absl import flags
Expand Down Expand Up @@ -331,23 +330,6 @@ def SetDbConfiguration(self, name: str, value: str) -> Tuple[str, str, int]:
]
return vm_util.IssueCommand(cmd, raise_on_failure=False)

def _IsInstanceReady(self, timeout: int = IS_READY_TIMEOUT) -> bool:
"""See base class."""
start_time = datetime.datetime.now()

while True:
if (datetime.datetime.now() - start_time).seconds >= timeout:
logging.warning('Timeout waiting for sql instance to be ready')
return False

server_show_json = self._AzServerShow()
if server_show_json is not None:
state = server_show_json['state']
if state == 'Ready':
break
time.sleep(5)
return True

def _ApplyDbFlags(self) -> None:
"""Apply database flags to the instance."""
for flag in FLAGS.db_flags:
Expand Down
Loading
Loading