Skip to content

Conversation

@08volt
Copy link

@08volt 08volt commented Oct 8, 2025

  • Created CustomResourceDefinition for ServiceLoadBalancerStatus.
  • Implemented the ServiceLoadBalancerStatus client with CRUD operations.
  • Added openapi code generation.
  • Added fake client for testing purposes.
  • Generated informers and listers for ServiceLoadBalancerStatus resources.
  • Ensured all generated code adheres to the Kubernetes API conventions.

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 08volt
Once this PR has been reviewed and has the lgtm label, please assign thebeezee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Contributor

Hi @08volt. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@08volt 08volt marked this pull request as ready for review October 8, 2025 10:39
@08volt 08volt force-pushed the lb-status-crd-clean branch from ba4c3cf to 87d477a Compare October 9, 2025 13:29
- Created CustomResourceDefinition for ServiceLoadBalancerStatus.
- Implemented the ServiceLoadBalancerStatus client with CRUD operations.
- Added fake client for testing purposes.
- Generated informers and listers for ServiceLoadBalancerStatus resources.
- Ensured all generated code adheres to the Kubernetes API conventions.
@08volt 08volt force-pushed the lb-status-crd-clean branch from 87d477a to cc8d454 Compare October 9, 2025 15:35
@google-oss-prow
Copy link
Contributor

@08volt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@08volt
Copy link
Author

08volt commented Oct 17, 2025

/assign @mskrocki ( just need ok to test )

@mskrocki
Copy link

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants