fix(remove-dep-on-ts-proto): Removes unnecessary ts-proto dependency#148
Merged
dkoss merged 1 commit intoGoogleCloudPlatform:mainfrom Jun 9, 2025
Merged
Conversation
adamfweidman
approved these changes
Jun 6, 2025
dkoss
force-pushed
the
remove-taffy-db-from-deps
branch
6 times, most recently
from
e3ed3a1 to
c9b8920
Compare
adamfweidman
approved these changes
Jun 9, 2025
dkoss
force-pushed
the
remove-taffy-db-from-deps
branch
4 times, most recently
from
5b4f738 to
2491238
Compare
…oto dependency and upgrade puppeteer * removes ts-proto to fix GoogleCloudPlatform#141 * upgrades puppeteer to newest version as it could no longer be installed directly
dkoss
force-pushed
the
remove-taffy-db-from-deps
branch
from
2491238 to
eac7cb4
Compare
adamfweidman
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes non-dev dependency on ts-proto, which had an indirect dependency on the taffydb module. https://nvd.nist.gov/vuln/detail/CVE-2019-10790.
Additionally: the ci workflow needed to be updated for the following reasons...
ubuntu-latesttoubuntu-22.04, to account for Puppeteer library unable to launch browser - "No usable sandbox!" puppeteer/puppeteer#13595, where the latest image of ubuntu no longer supports puppeteer out of the box.main)npm ci --verbosetwice, instead ofnpm installso that progress in that step is obvious (it takes ~7 minutes to run on github actions)