Skip to content

Fix for marker content update bug #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for marker content update bug #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
774f668
Fix for marker content update bug
tst-dhudlow Apr 27, 2016
820bc9d
Add test to reproduce problem
tst-dhudlow Jun 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions google-map-marker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@
if (this.marker) {
this.marker.setMap(this.map);
}
this._contentChanged();
},

_updatePosition: function() {
Expand Down
1 change: 1 addition & 0 deletions test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
'google-map-basic.html',
'google-map-update-pos.html',
'marker-basic.html',
'marker-advanced.html',
'markers-add-remove.html',
'poly-basic.html'
]);
Expand Down
84 changes: 84 additions & 0 deletions test/marker-advanced.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
<!doctype html>
<!-- Copyright (c) 2014 Google Inc. All rights reserved. -->
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<script src="../../webcomponentsjs/webcomponents.js"></script>
<script src="../../web-component-tester/browser.js"></script>
<link rel="import" href="../google-map.html">
</head>

<body>
<dom-module id="marker-tester-element">
<template>
<google-map id="map1" map="{{map}}" latitude="37.77493" longitude="-122.41942"></google-map>

<template is="dom-repeat" items="{{markers}}" id="markerRepeat">
<google-map-marker map="{{map}}" id="marker1" latitude="37.777" longitude="-122.38911" >
<h1>{{item.name}}</h1>
</google-map-marker>
</template>
</template>
<script>
(function() {
'use strict';

Polymer({
is: 'marker-tester-element',

properties: {
markers: {
type: Array,
value: [ { name: "Something "} ]
}
},

attached: function() {
// Run tests
this.test();
},

test: function() {
var that = this;
var map = this.$.map1;

suite('markers', function() {

test('defaults', function(done) {
var markerEl = that.$$('google-map-marker');
that.name = "Nothing";

// Get rid of markers and then add them back to trigger
// dom-repeat re-use cycle
that.markers = [];

map.addEventListener('google-map-ready', function(e) {
that.markers = [ { name: "Something" } ];

flush(function() {
var markerEl = that.$$('google-map-marker');

// Verify basic stuff still works
assert.isDefined(markerEl.marker);
assert.isDefined(markerEl.info);
assert.equal(markerEl.latitude, 37.777);
assert.equal(markerEl.longitude, -122.38911);

// Verify that InfoWindow content is up-to-date
assert.include(markerEl.info.content, "Something");

done();
});
});
});
});
}
});
})();
</script>
</dom-module>
<marker-tester-element></marker-tester-element>
</body>

</html>