Add dates() utility function for explicit year-to-date mappings#151
Merged
Add dates() utility function for explicit year-to-date mappings#151
Conversation
Introduce a new dates() function in utils.py that provides a cleaner way to define holidays with explicit year-to-date mappings, replacing static methods in region classes. - Add dates() function to utils.py for mapping years to specific dates - Refactor AU/SA, AU/VIC, AU/WA, ES/CE, ES/ML, SG, and TR regions to use dates() - Remove redundant static methods for holiday date calculations This simplifies holiday definitions by allowing inline date mappings with optional fallback to dynamic date calculations via or_else_on(). Other changes: - Improve type hinting in HolidayGenerator (date field now accepts None) - Remove callable validation in on() method for simpler API - Fix easter_type type hint from str to int in Country class Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
a350883 to
285f63c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new dates() function that provides a cleaner way to define holidays with explicit year-to-date mappings, replacing static methods in region classes.
This simplifies holiday definitions by allowing inline date mappings with optional fallback to dynamic date calculations via or_else_on().
Example: