CLI: Reserve arguments that start with ':' for hints#363
Open
sruffell wants to merge 1 commit intoGothenburgBitFactory:devfrom
Open
CLI: Reserve arguments that start with ':' for hints#363sruffell wants to merge 1 commit intoGothenburgBitFactory:devfrom
sruffell wants to merge 1 commit intoGothenburgBitFactory:devfrom
Conversation
sruffell
force-pushed
the
reserve-colon-for-hints
branch
2 times, most recently
from
7b2fd1c to
fe42fa9
Compare
lauft
reviewed
Aug 19, 2020
Member
lauft
left a comment
lauft
left a comment
There was a problem hiding this comment.
Lookin good so far, but I think we need also to address cases when a user tries to (un)tag an interval with a (pseudo-)hint, e.g.:
timew (un)tag @1 :quiet # should already be handled...
timew (un)tag @1 :unknown
timew (un)tag @1 FOO :unknown
sruffell
force-pushed
the
reserve-colon-for-hints
branch
from
fe42fa9 to
c22375b
Compare
Contributor
Author
I'm not sure I understand? Anytime an invalid hint is specified, timewarrior will report the error halt. Here is the behavior in the current iteration of this pull request: What is the expected behavior in this case? |
Currently, any argument that starts with ':' that isn't a known hint will be treated as a tag. After this change, an error is produced. Hopefully there were not users who were using tags that start with a colon... Closes GothenburgBitFactory#348 Signed-off-by: Shaun Ruffell <sruffell@sruffell.net>
sruffell
force-pushed
the
reserve-colon-for-hints
branch
from
c22375b to
b348dba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, any argument that starts with ':' that isn't a known hint
will be treated as a tag. After this change, an error is produced.
Hopefully there were not users who were using tags that start with a
colon...
Closes #348