This repository was archived by the owner on May 25, 2026. It is now read-only.
feat(post-edit): first-correction terminal notification (GRA-1202)#20
Open
Gradata wants to merge 5 commits into
Open
feat(post-edit): first-correction terminal notification (GRA-1202)#20Gradata wants to merge 5 commits into
Gradata wants to merge 5 commits into
Conversation
- telemetry.js: add ensureInstallId, determineCohort (hash-based 50/50), sendTelemetryEvent - install.js: replace opt-in env-var with deterministic cohort assignment; emit install_completed event with install_id + cohort at end of main() - session-stop.js: emit first_rule_injected once per install on first session where rules were active; guarded by ~/.gradata/.first_rule_injected flag file - tests: add determineCohort determinism + edge-case tests Unblocks: GRA-221 (7-day multi_cli_install_success_rate window)
Replace README with archive pointer. Previous content preserved at README.legacy.md for git history walkers. Ref: GRA-1250
When the first-ever lesson is created via a daemon /correct call, print '[Gradata] 1 correction captured. lesson created. View: gradata lessons --recent' to stderr. Uses ~/.gradata/first-notification-sent sentinel file to ensure the message fires only once across all sessions. Subsequent corrections remain silent. Closes: d637ca6f-880d-432d-b9ce-1ddf3c6db8f7
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the very first lesson is created via the post-edit hook → daemon /correct call, print a one-time message to stderr:
Uses a sentinel file (~~/.gradata/first-notification-sent) to ensure the message fires exactly once across all sessions. Subsequent corrections remain silent.
Why
GRA-1202 / onboarding funnel research: the highest install-to-aha drop-off is after the first correction — users see no visible response and assume the product isn't working. One confirmation message proves it's alive.
Test plan
node --check hooks/post-edit.jspasses~/.gradata/first-notification-sentRisk
None. Additive change, best-effort only, backwards compatible.
Closes: d637ca6f-880d-432d-b9ce-1ddf3c6db8f7