Add support for setting video frame rate #436
Conversation
MHShetty
force-pushed
the
video_frame_rate
branch
from
8427d99 to
e7571b6
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
a8a8831 to
5322053
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
c41cd08 to
499bcfc
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
from
499bcfc to
bc0438d
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
5712181 to
4d75174
Compare
|
The video frame rate despite being set correctly doesn't seem to reflect on the video currently. We could merge this PR once this gets resolved on CameraX |
MHShetty
force-pushed
the
video_frame_rate
branch
from
4d75174 to
655f6aa
Compare
|
The latest changes made in the recent release does fix the issue with uncertainties with lower ranges on my Pixel 7A. However, the issue still persists for 60 fps, where recording a video while choosing a 60-fps range (from the list of supported ranges reported by the library) doesn't make the fps of the recorded video close to the selected range. Have filed an issue for the same on CameraX's issue tracker: https://issuetracker.google.com/issues/384146331 |
thestinger
force-pushed
the
main
branch
4 times, most recently
from
cd641d6 to
4caeaf1
Compare
(for frame rate per second setting)
(in quick settings dialog)
(show appropriate options in dropdown and selection of default fps)
(and prevent crash when video mode is directly turned on)
MHShetty
force-pushed
the
video_frame_rate
branch
from
655f6aa to
ec50bf3
Compare
(for frame rate per second setting)
MHShetty
force-pushed
the
video_frame_rate
branch
from
ec50bf3 to
6ac1e56
Compare
thestinger
force-pushed
the
main
branch
2 times, most recently
from
6b28894 to
00870f6
Compare
thestinger
force-pushed
the
main
branch
2 times, most recently
from
18723e0 to
46ff422
Compare
|
We might finally be able to have this feature in our app by the next CameraX release |
|
A fix is available for this in the latest release: https://issuetracker.google.com/issues/384146331#comment20 Will update this PR for the same once its implemented and tested on our end |
|
We have found some issues with the new API, could take a while before it gets resolved. Might need to drop persistency to support varying combinations of video settings correctly |
Adds support to set fps of the video being recorded (Issue #51)
(Needs testing to check if the set fps actually reflects in the video across different devices, especially at 60 fps for devices that support it)