ADBDEV-10027: stop building pxf when prepare docker images for integration tests - #50
Open
AngryX wants to merge 1 commit into
Open
ADBDEV-10027: stop building pxf when prepare docker images for integration tests#50AngryX wants to merge 1 commit into
AngryX wants to merge 1 commit into
Conversation
AngryX
force-pushed
the
features/ADBDEV-10027_1
branch
from
July 2, 2026 13:18
a2de5f3 to
08d49d4
Compare
magf
reviewed
Jul 3, 2026
Comment on lines
+66
to
+75
| - name: Set up Java 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
|
|
||
| - name: Build PXF Java server artifacts | ||
| working-directory: server | ||
| run: ./gradlew stage -x test | ||
|
|
Collaborator
There was a problem hiding this comment.
We don't push processes to the runner level.
All processes should be executed in scripts identically in any environment, such as locally.
The runner serves only as a formal launch environment.
We don't need a runner-lock.
magf
reviewed
Jul 3, 2026
Comment on lines
-5
to
-9
| # Fail early if GPHOME not found | ||
| ifeq ($(GPHOME),) | ||
| $(error GPHOME not defined) | ||
| endif | ||
|
|
Collaborator
There was a problem hiding this comment.
Why are we globally ignoring the absence of GPHOME?
This may cause the PXF to build with the wrong path - at the root of FS.
magf
requested changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.