Skip to content

Conversation

@pranavkparti
Copy link
Collaborator

Description

The schema validations are fixed for errors and parameters.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
The validation is inconsistent across the endpoints.

What is the new behavior?

The changes include:

  • GET /tokens/:id/transactions -> removed unnecessary parameters, added validation for id
  • GET /tokens/:id -> added validation for id
  • GET /trust_relationships -> added limit as a required parameter
  • Added min, max, for limit and offset
  • etc.

Breaking change

Does this PR introduce a breaking change?
No.

Other useful information

None.

@pranavkparti pranavkparti requested a review from Kpoke September 14, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant