Skip to content

Conversation

kriswillis
Copy link

@kriswillis kriswillis commented May 11, 2016

If a custom adapter is written, there was no way to configure the bundle to use it; this pull request adds this functionality.

@@ -25,6 +25,7 @@ public function getConfigTreeBuilder()
->booleanNode('throw_exception')->defaultFalse()->end()
->scalarNode('fallback_image')->defaultNull()->end()
->scalarNode('web_dir')->defaultValue('%kernel.root_dir%/../web')->end()
->scalarNode('adapter')->defaultValue('gd')->end()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a class name and will not work.

I think it would be better to create services of adapters and configure the service name instead.

BTW, maybe can you write some tests using this library? https://packagist.org/packages/matthiasnoback/symfony-dependency-injection-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants