feat: split batches before merge #7225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
docs-not-required
evenyag
changed the title
It checks the num_series and splits batches when the series cardinality is low Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
evenyag
force-pushed
the
feat/flat-split-batch
branch
from
da229c7 to
b28659c
Compare
waynexia
approved these changes
Nov 18, 2025
fengjiachun
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#6078
What's changed and what's your intention?
In flat format, split batches before merge if the series number is less than
NUM_SERIES_THRESHOLDor each batch after splitting still hasBATCH_SIZE_THRESHOLDrows. This may improve the merge performance.We may need to further adjust the two threshold after testing on real workloads.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.