Added Windows support, Fixed UnicodeDecode error and made some improvements #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a few improvements. Started by adding Windows support, which inadvertently ended up fixing a lot of problems for linux and macos as well. Changes: - Windows support Because cmd prompt and powershell do env variables differently, this required figuring out which one the user is using. Then changing the console outputs to reflect which cli the user is using. (this includes macos and linux, it always outputs the correct commanad) -Removed pycookiecheat in favor of browser_cookie3 Initially browser_cookie3 was implemented for windows users since pycookiecheat is macos/linux only. However upon further investigation, the utf decode issues on macos and linux are caused by pycookiecheat. Changing the code to use browser_cookie3 fixed these issues -code rewrite Since the code now needs to check if the user in on windows and whether or not theyre using cmd prompt, it was easier to break down the code into multiple functions. This allows for much more control and cleaner output. -Exclusion Filter There is now one variable to control what parts you want to remove from the final printout. Updating this as time goes on will make troubleshooting easier for everyone. Hopefully this solves the majority of "me me cookie no work" posts Just in case I forget, browser_cookie3 needs to be added to the requirements and the script in the repo's root directory also need to be changed.
Made a few improvements. Started by adding Windows support, which inadvertently ended up fixing a lot of problems for linux and macos as well. Changes: - Windows support Because cmd prompt and powershell do env variables differently, this required figuring out which one the user is using. Then changing the console outputs to reflect which cli the user is using. (this includes macos and linux, it always outputs the correct commanad) -Removed pycookiecheat in favor of browser_cookie3 Initially browser_cookie3 was implemented for windows users since pycookiecheat is macos/linux only. However upon further investigation, the utf decode issues on macos and linux are caused by pycookiecheat. Changing the code to use browser_cookie3 fixed these issues -code rewrite Since the code now needs to check if the user in on windows and whether or not theyre using cmd prompt, it was easier to break down the code into multiple functions. This allows for much more control and cleaner output. -Exclusion Filter There is now one variable to control what parts you want to remove from the final printout. Updating this as time goes on will make troubleshooting easier for everyone. Hopefully this solves the majority of "me me cookie no work" posts Just in case I forget, browser_cookie3 needs to be added to the requirements and the script in the repo's root directory also need to be changed.
|
Forgot to mention that the url used for looking up cookies isn't the same one used in the url variable. Chrome on Windows stores the domain name without the wildcards. So the url used in the variable doesn't work on Windows. For reasons im not entirely sure, just using openai.com works on both linux and windows. |
|
The solution looks perfect! Thanks for the contribution. I'll test it with your branch and merge the code if everything works. |
|
I just did some local testing, but it does not work on MacOS native terminal + Chrome. I'll debug on Ubuntu and see what is the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few improvements. Tested on Windows, Kali and Mint. Hopefully there aren't any oversights. I Started by adding Windows support, which inadvertently ended up fixing a lot of problems for linux and macos as well.
Changes:
Windows support
Because cmd prompt and powershell do env variables differently, this required figuring out which one the user is using. Then changing the console outputs to reflect which cli the user is using. (this includes macos and linux, it always outputs the correct command)
Removed pycookiecheat in favor of browser_cookie3
Initially browser_cookie3 was implemented for windows users since pycookiecheat is macos/linux only. However upon further investigation, the utf decode issues on macos and linux are caused by pycookiecheat. Changing the code to use browser_cookie3 fixed these issues
code rewrite
Since the code needs to check if the user is on windows and whether or not theyre using cmd prompt, it was easier to break the code down the into multiple functions. This allows for much more control and cleaner output. It's also slightly annoying to look at
Exclusion Filter
There is now one variable that controls which field you wish to remove from the final output. Updating this as time goes on will make troubleshooting easier for everyone. Hopefully this solves some of the tuple errors