Skip to content

feat: 프로필 페이지에 대한 디자인 시스템 적용#180

Merged
MTtankkeo merged 2 commits into
mainfrom
profile
Jun 26, 2026
Merged

feat: 프로필 페이지에 대한 디자인 시스템 적용#180
MTtankkeo merged 2 commits into
mainfrom
profile

Conversation

@MTtankkeo

Copy link
Copy Markdown
Member

작업 내용

  • 프로필 페이지 전반에 GDS 기반 디자인 시스템 컴포넌트 적용
  • 프로필 상단 영역, 앱바, 탭바, 배경 이미지, 게시물/글 목록 UI 정리
  • 프로필 링크 표시 방식을 GDS BottomSheet/Modal 기반 팝업으로 변경
  • 프로필 그림/글 탭의 정렬 헤더 및 정렬 옵션 처리 추가
  • 공유 팝업에서 링크 복사 성공 토스트 표시 추가

변경 사항

  • 기존 AlbumChip, 프로필 링크 바텀시트 등 레거시 위젯 제거
  • GrimityPostFeed에 sliver 렌더링 옵션 추가
  • 프로필 게시글 정렬 옵션을 별도로 분리
  • 프로필 링크 타입 판별 로직 개선

피그마 참고

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the profile-related UI components to adopt the GDS (Grimity Design System) components, replacing legacy widgets with GDS alternatives (such as GdsCategory, GdsThumbnail, GdsBottomSheet, GdsModal, and GdsTab). Feedback on the changes highlights several logical and safety issues, including incorrect follow button visibility logic, a missing 'mailto:' schema for email links, a missing early return when user authentication fails during account deletion, and a potential StateError when looking up deleted albums. Additionally, suggestions were made to clean up redundant checks, dead code, and simplify link wrapping logic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/profile/view/user_profile_view.dart Outdated
Comment thread lib/presentation/profile/view/user_profile_view.dart Outdated
Comment thread lib/presentation/profile/widget/profile_link_popup.dart
Comment thread lib/presentation/profile/view/profile_feed_tab_view.dart Outdated
Comment thread lib/presentation/profile/view/user_profile_view.dart
Comment thread lib/presentation/profile/view/user_profile_view.dart
Comment thread lib/presentation/profile/widget/profile_tab_bar.dart Outdated
@MTtankkeo MTtankkeo merged commit 4072d1b into main Jun 26, 2026
1 check passed
@MTtankkeo MTtankkeo deleted the profile branch June 28, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant