Skip to content

feat: 글 업로드 페이지에 대한 디자인 시스템 적용#183

Merged
MTtankkeo merged 2 commits into
mainfrom
post_upload
Jul 6, 2026
Merged

feat: 글 업로드 페이지에 대한 디자인 시스템 적용#183
MTtankkeo merged 2 commits into
mainfrom
post_upload

Conversation

@MTtankkeo

Copy link
Copy Markdown
Member

작업 내용

글 업로드 페이지 전반에 GDS 기반 디자인 시스템을 적용했습니다용.

  • 글 업로드 화면 구조를 GdsScaffold 기반으로 정리
  • 제목/본문 입력 영역에 GDS 타이포그래피 및 입력 스타일 적용
  • 업로드 타입 선택 UI를 GDS popup 기반으로 변경
  • 에디터 툴바를 GDS GdsEditor 기반으로 교체
  • 링크 추가 UI를 GDS BottomSheet/Modal 기반 popup으로 변경
  • 이미지 클릭 시 별도 삭제 바텀시트 없이 바로 제거되도록 동작 단순화
  • 업로드 진행 중 안내 UI 문구 및 레이아웃 정리

피그마 참고

모바일: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1034-82380&m=dev
테블릿: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1001-267286&m=dev

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates various UI components, typography, and colors to the GDS (Grimity Design System) library, including refactoring the post upload toolbar into a unified PostUploadToolbar using GdsEditor. It also simplifies the image deletion flow in the editor and removes unused album organization components. Feedback on these changes highlights a critical bug where the text controller was omitted in the new GdsTextField.title, which prevents existing titles from displaying when editing a post. Additionally, a context.mounted check is recommended after the asynchronous image upload route to ensure safe state updates.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/post_upload/widget/post_upload_toolbar.dart
@MTtankkeo MTtankkeo merged commit 442150e into main Jul 6, 2026
1 check passed
@MTtankkeo MTtankkeo deleted the post_upload branch July 7, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant