Skip to content

feat: 로그인 페이지에 대한 디자인 시스템 적용#185

Merged
MTtankkeo merged 1 commit into
mainfrom
sign_in
Jul 7, 2026
Merged

feat: 로그인 페이지에 대한 디자인 시스템 적용#185
MTtankkeo merged 1 commit into
mainfrom
sign_in

Conversation

@MTtankkeo

@MTtankkeo MTtankkeo commented Jul 7, 2026

Copy link
Copy Markdown
Member

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 7, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the sign-in page to integrate the new GDS (Grimity Design System) package. It replaces the custom SignInMediaWallView with GdsAppLogin, introduces a unified SSOButton widget, and updates typography, spacing, and colors to align with GDS standards. Feedback is provided to replace legacy colors in the new SSOButton with GDS tokens and to use const constructors where possible to optimize rendering performance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/sign_in/widget/sso_button.dart Outdated
Comment thread lib/presentation/sign_in/sign_in_page.dart
@MTtankkeo MTtankkeo merged commit 4db5e89 into main Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MTtankkeo