Open
Conversation
Sintendo
commented
Oct 17, 2022
Sintendo
commented
- Upgrade catch to v2.13.10 for Apple silicon support
- Add Frida Gum static library for macOS ARM64
added 2 commits
October 17, 2022 11:56
The old version did not have support for Apple silicon.
Contributor
|
Which version of gum was used? We have to make sure the versions are in sync as they use the same headers. |
|
|
||
| if (APPLE) | ||
| set(ARCHITECTURE_PATH x86_64 ) | ||
| if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "arm64") |
Contributor
There was a problem hiding this comment.
Use CMAKE_SYSTEM_PROCESSOR. When cross-compiling, the target architecture can be different than the host architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.