Correctly rename InvokeDynamic method references during obfuscation#156
Open
ShortyDev wants to merge 2 commits intoGuardsquare:masterfrom
Open
Correctly rename InvokeDynamic method references during obfuscation#156ShortyDev wants to merge 2 commits intoGuardsquare:masterfrom
ShortyDev wants to merge 2 commits intoGuardsquare:masterfrom
Conversation
| * | ||
| * @author ShortyDev | ||
| */ | ||
| public class LambdaReferenceInitializer implements ClassVisitor, ConstantVisitor { |
Contributor
There was a problem hiding this comment.
this class is completely unused outside of javadoc, what is the purpose?
Contributor
There was a problem hiding this comment.
I think what you actually want to do is modify the visitInvokeDynamicConstant implementation of the ClassReferenceInitializer, and drop the new class.
| * | ||
| * <p>The class hierarchy must be initialized before using this visitor. | ||
| * | ||
| * @author ShortyDev |
Contributor
There was a problem hiding this comment.
please remove author tag
Contributor
|
Please make sure to add a reproducing test that justifies this code :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables ProGuard to track and update the method name in invokedynamic instructions (Lambdas) when the target Functional Interface method is renamed. Previously, only the descriptor type was updated, leading to a mismatch between the instruction name and the actual interface method.
Changes:
Relevant issue:
Guardsquare/proguard#512