Fix LeafMoveMatcherThetaE #393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouryafard75
temporarily deployed
to
MavenCentral
GitHub Actions
Inactive
|
Before fix: After fix: |
|
@jrfaller This one is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
ThetaEoptimization logic where adding a new mapping could leavesrcToDstanddstToSrcinconsistent.In certain cases, a new mapping is added without first removing existing conflicting entries. This can cause one of the maps to still hold the old mapping, leading to lost mappings in the final result.
Example commit demonstrating the issue:
pouryafard75/TestCases@fb4498b
Before optimization:
After optimization:
My proposed fix:
Before adding a new mapping, clear any existing entries in both
srcToDstanddstToSrcthat conflict with it. This ensures the maps remain consistent.