-
Notifications
You must be signed in to change notification settings - Fork 2
Serialized the analyzing tiers to persist state #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3fcb0e0
2996701
a064a95
a96e8f4
1bdd56a
60fa4d2
85b1966
b83d7ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| FROM ubuntu:hirsute | ||
| FROM ubuntu:jammy | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did this change? |
||
| # clean and update sources | ||
| RUN apt-get -y update | ||
| # Ubuntu 21.04 | ||
|
|
||
| # with ubuntu:impish, get an error on apt update | ||
|
|
@@ -13,11 +15,11 @@ ENV TZ=Europe/Stockholm | |
| RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone | ||
|
|
||
| # Always run update when changing package list, see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/ | ||
| RUN apt update ; echo 'editthistoforcerun5' | ||
| #RUN apt update ; echo 'editthistoforcerun5' | ||
|
|
||
| # install curl | ||
| RUN apt install -y curl | ||
| RUN apt install -y openjdk-16-jre | ||
| RUN apt install -y openjdk-18-jre | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did this change? |
||
|
|
||
| RUN java --version | ||
|
|
||
|
|
@@ -42,8 +44,8 @@ RUN curl -LO "https://dl.k8s.io/release/v1.22.3/bin/linux/amd64/kubectl" | |
| RUN install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl | ||
| RUN kubectl version --client | ||
|
|
||
| COPY build/libs/hom-impl-2.manager-1.0-SNAPSHOT.jar output.jar | ||
| COPY hom-impl-2.manager-1.0-SNAPSHOT.jar output.jar | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure. isn't the path here set by gradle? |
||
|
|
||
| # /usr/lib/jvm/jdk-17/bin/java -cp output.jar com.benblamey.hom.manager.ManagerMainTest | ||
| #ENTRYPOINT ["java","-jar","output.jar"] | ||
| ENTRYPOINT ["/bin/bash"] | ||
| ENTRYPOINT ["/bin/bash"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| import java.util.Map; | ||
|
|
||
| // Placeholder for existin Kafka stream repr. the input source for the system. | ||
| public class InputTier extends Tier { | ||
| public class InputTier extends Tier { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ideally want to avoid making changes like this |
||
|
|
||
| Logger logger = LoggerFactory.getLogger(InputTier.class); | ||
| static final int tierId = 0; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,15 +17,15 @@ public static List<String> getFunctions(String directory) throws IOException, In | |
| "bash", | ||
| "-ec", | ||
| // Unescaped: | ||
| // grep --extended-regexp --only-matching "^\s*\"\s*def ([^(])+\(" *.ipynb | sed -E "s/(.+):\s+\"def (.+)\(/\1,\2/" | ||
| "grep --extended-regexp --only-matching \"^\\s*\\\"def ([^(])+\\(\" *.ipynb | sed -E \"s/(.+):\\s+\\\"def (.+)\\(/\\1::\\2/\"" | ||
| }, new File(directory), null, true).stdOut; | ||
| // grep --extended-regexp --only-matching "^\s*\"\s*def\s*[_a-zA-Z]+\w*\([_a-zA-Z]+\w*\)" *.ipynb | sed -E "s/(.+):\s+\"def (.+)\(/\1,\2/" | ||
| "grep --extended-regexp --only-matching \"^\\s*\\\"def\\s*[_a-zA-Z]+\\w*\\([_a-zA-Z]+\\w*\\)\" *.ipynb | sed -E \"s/(.+):\\s+\\\"def (.+)\\(/\\1::\\2/\"" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lol! |
||
|
|
||
| }, new File(directory), null, true).stdOut; | ||
| return Arrays.stream(stdOut.split("\n")).toList(); | ||
| } | ||
|
|
||
| // For testing... | ||
| public static void main(String[] args) throws IOException, InterruptedException { | ||
| getFunctions("/Users/benblamey/projects/github-me/hom-impl-2/persistentvolume"); | ||
| getFunctions("C:\\Users\\Savior_Hn\\Desktop\\HASTE-o-MATIC-main\\HASTE-o-MATIC-main\\persistentvolume"); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.benblamey.hom.manager; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonGenerationException; | ||
| import com.fasterxml.jackson.core.JsonParseException; | ||
| import com.fasterxml.jackson.databind.JsonMappingException; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.dataformat.xml.XmlMapper; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is maybe not necessary to commit changes like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i understand its a bit of a muddle. we don't exactly have a great CI process here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I make these changes to fix the docker image build problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough should upgrade them. I didn't realise it had got so old.... SNIC is still using Ubuntu 20.